This combination is a bit of an interesting case, mechanically. To qualify for the multiclass, a character needs a 13 in Strength, Dexterity, and Charisma. Once that has been achieved, however, it’s perfectly viable to pick just one of the physical ability scores and focus on that and Charisma for the rest of the character’s career. Both classes get access to maneuvers as well, and while the rogue (usually; there are some tertiary caster archetypes available) won’t advance the spellcasting of the herald component of the build, both classes like to hit really hard.
Flavor is also an interesting case. The stereotype of the shining divine champion and the sneaky criminal constantly bickering and getting on one another’s nerves is as old as the hills, but there’s really nothing mutually-exclusive about ideological commitment and covert skills. Depending on archetype choice, this pairing can feel very natural.
More levels of herald gives you a sturdy frontline warrior with some extra mobility (thanks to cunning action) and covert skills. More levels of rogue gives you a typical sneaky type who can perhaps use some heavier armaments and can draw upon a little magic in a pinch. An even mix of the two gives you a formidable and versatile midpoint between the two with significant magic, bonus damage, and combat prowess at their disposal.
[[Synergy Feats for Multiclassers#Herald w/ Rogue|Herald-Rogue chains and ideas]]